Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to pass description to display on hover of properties #6718

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

amal-k-joy
Copy link
Contributor

Closes #6717

Need to pass an optional description along with input properties and need to display that on mouse hover of property field

What did you change?

Added a description property to the input config to display on hover/focus of property field

How did you test and verify your work?

local

@amal-k-joy amal-k-joy requested a review from a team as a code owner January 16, 2025 09:38
@amal-k-joy amal-k-joy requested review from AlexanderMelox and sangeethababu9223 and removed request for a team January 16, 2025 09:38
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 6e7aa37
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6791c24eb7bbb50008aa8a08
😎 Deploy Preview https://deploy-preview-6718--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 6e7aa37
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6791c24e36e3b40008472e84
😎 Deploy Preview https://deploy-preview-6718--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (37dba95) to head (6e7aa37).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6718   +/-   ##
=======================================
  Coverage   80.90%   80.91%           
=======================================
  Files         398      398           
  Lines       12953    12954    +1     
  Branches     4280     4281    +1     
=======================================
+ Hits        10480    10482    +2     
+ Misses       2473     2472    -1     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. one change requested and can you please add any additional tests that are required for codecov? thanks!

@davidmenendez
Copy link
Contributor

@amal-k-joy any updates here?

@amal-k-joy
Copy link
Contributor Author

@amal-k-joy any updates here?

Hi @davidmenendez ,
I think I have made the changes as per your comment in this commit
Just wondering if i missed anything else here?

@amal-k-joy amal-k-joy added this pull request to the merge queue Jan 28, 2025
Merged via the queue into carbon-design-system:main with commit d043ffa Jan 28, 2025
32 checks passed
@amal-k-joy amal-k-joy deleted the conditionbuilder6717 branch January 28, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Display an optional description on hover of property field as passed by the user
3 participants