-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to pass description to display on hover of properties #6718
feat: add option to pass description to display on hover of properties #6718
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6718 +/- ##
=======================================
Coverage 80.90% 80.91%
=======================================
Files 398 398
Lines 12953 12954 +1
Branches 4280 4281 +1
=======================================
+ Hits 10480 10482 +2
+ Misses 2473 2472 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. one change requested and can you please add any additional tests that are required for codecov? thanks!
...m-products/src/components/ConditionBuilder/ConditionBuilderButton/ConditionBuilderButton.tsx
Outdated
Show resolved
Hide resolved
@amal-k-joy any updates here? |
…ucts into conditionbuilder6717
Hi @davidmenendez , |
d043ffa
Closes #6717
Need to pass an optional description along with input properties and need to display that on mouse hover of property field
What did you change?
Added a description property to the input config to display on hover/focus of property field
How did you test and verify your work?
local